Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-1336 #856

Merged
merged 12 commits into from
Jan 13, 2025
Merged

feat: CE-1336 #856

merged 12 commits into from
Jan 13, 2025

Conversation

nayr974
Copy link
Collaborator

@nayr974 nayr974 commented Jan 8, 2025

https://env-ceds.atlassian.net/browse/CE-1336

Demo WEBEOC has not been updated with the new option, but test old value continues to map to NatCom and that the updated text appears in NatCom.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@nayr974 nayr974 closed this Jan 8, 2025
@nayr974 nayr974 reopened this Jan 8, 2025
@nayr974 nayr974 changed the base branch from main to release/0.6.12 January 8, 2025 17:28
@nayr974 nayr974 closed this Jan 8, 2025
@nayr974 nayr974 reopened this Jan 8, 2025
@nayr974 nayr974 closed this Jan 8, 2025
@nayr974 nayr974 reopened this Jan 8, 2025
@nayr974 nayr974 added the not ready Not ready for review, WIP, do not merge. label Jan 8, 2025
@nayr974 nayr974 closed this Jan 9, 2025
@nayr974 nayr974 removed the not ready Not ready for review, WIP, do not merge. label Jan 9, 2025
@nayr974 nayr974 reopened this Jan 9, 2025
@nayr974
Copy link
Collaborator Author

nayr974 commented Jan 9, 2025

Demo WEBEOC has not been updated with the new option, but test old value continues to map to NatCom and that the updated text appears in NatCom.

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because webEOC has already started using these values (without telling us) we need to build a data conversion script based on the short description (as webEOC doesn't have codes)

We will also need to delete the values from the nature of complaint code table as well as we don't want them to be selectable by users.

edit: nothing you've built needs to change though

@nayr974 nayr974 closed this Jan 10, 2025
@nayr974 nayr974 reopened this Jan 10, 2025
@nayr974
Copy link
Collaborator Author

nayr974 commented Jan 10, 2025

@afwilcox I've updated the V0.33 script to also handle any new codes and mappings were potentially created from prod data, update any complaints with these codes to the desired ones, then inactive them.

@nayr974 nayr974 requested a review from afwilcox January 10, 2025 19:28
@nayr974 nayr974 closed this Jan 13, 2025
@nayr974 nayr974 reopened this Jan 13, 2025
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@nayr974 nayr974 closed this Jan 13, 2025
@nayr974 nayr974 reopened this Jan 13, 2025
@nayr974 nayr974 closed this Jan 13, 2025
@nayr974 nayr974 reopened this Jan 13, 2025
@afwilcox afwilcox merged commit 2ce000a into release/0.6.12 Jan 13, 2025
58 of 62 checks passed
@afwilcox afwilcox deleted the CE-1336 branch January 13, 2025 22:00
github-merge-queue bot pushed a commit that referenced this pull request Jan 15, 2025
Co-authored-by: afwilcox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants